Issue

The attack move sim callback relies on position data written in lua on the user side, which allows for automation of attack move orders.

Description of the proposed changes

Thanks to an engine patch the sim can inspect a unit's command queue.

• Change the callback to get the target position from the command queue.
  • There is no way to add a position to that command queue data automatically, so the automation is fixed.
• related annotations

Testing done on the proposed changes

• Use the attack move button to issue shift/not shift attack moves
• Use this script (use in clipboard) to see that it doesn't work for lua script tasks:

    IssueUnitCommandToUnit(GetSelectedUnits()[1], "UNITCOMMAND_Script", {TaskName = 'AttackMove'})

• And this one to see the callback doesn't work automatically.

    local cb = { Func = "AttackMove", Args = { Clear = true, Target = {50, 50, 50} } }
    SimCallback(cb, true)

An unavoidable part of the implementation since the very beginning is that the unit queue is filled with useless script commands, so the unit is slightly unresponsive as it goes through the script command before moving on to the attack move task.

Checklist

• Changes are annotated, including comments where useful
• Changes are documented in the changelog for the next game version